tag:blogger.com,1999:blog-9150561117329868491.post3486392535617366725..comments2023-10-08T20:48:43.878+05:30Comments on My Journey Through IT: Its time for some code reviewDinuka Arseculeratnehttp://www.blogger.com/profile/13924080326710656628noreply@blogger.comBlogger10125tag:blogger.com,1999:blog-9150561117329868491.post-78110686478046587842011-05-09T15:04:10.006+05:302011-05-09T15:04:10.006+05:30@ arapidhs thx for your comment man.. Unfortunatel...@ arapidhs thx for your comment man.. Unfortunately i mistakenly pressed the delete button and erased your comment. So Sry mate. Thx for leaving by a comment. Cheers manDinuka Arseculeratnehttps://www.blogger.com/profile/13924080326710656628noreply@blogger.comtag:blogger.com,1999:blog-9150561117329868491.post-40670483074494949912011-03-26T19:39:34.454+05:302011-03-26T19:39:34.454+05:30your welcome.. glad you liked it.. Cheers manyour welcome.. glad you liked it.. Cheers manDinuka Arseculeratnehttps://www.blogger.com/profile/13924080326710656628noreply@blogger.comtag:blogger.com,1999:blog-9150561117329868491.post-74779662883789367032011-03-18T22:16:20.633+05:302011-03-18T22:16:20.633+05:30@Nicolas - Thx for your comment. Its very descrip...@Nicolas - Thx for your comment. Its very descriptive and many will benefit from it. Thx alot. As for your comments. The ten iterations was just for an example. what i tried to imply was that when you have alot of iterations its best not to use String concatenation.<br /><br />And also Integer i = 5 works and i prefer it too. But in most cases we use wrapper classes in the even when you need to Dinuka Arseculeratnehttps://www.blogger.com/profile/13924080326710656628noreply@blogger.comtag:blogger.com,1999:blog-9150561117329868491.post-54809475393819240302011-03-18T19:12:45.856+05:302011-03-18T19:12:45.856+05:30Nice comments only one comment, when you say that ...Nice comments only one comment, when you say that log.isDebugEnabled(), this condition is only aplicable for log4j logger familiy, for example in Logback this is not required.<br /><br />And one question I have also a blog, how do you do for creating source code with lines? Thank you very much and keep writing.Alexhttps://www.blogger.com/profile/11632964711752480304noreply@blogger.comtag:blogger.com,1999:blog-9150561117329868491.post-49350931264245613032011-03-18T18:07:26.464+05:302011-03-18T18:07:26.464+05:30whole article is a big wtf for me.whole article is a big wtf for me.Alexander Ashitkinhttps://www.blogger.com/profile/13064876744853072148noreply@blogger.comtag:blogger.com,1999:blog-9150561117329868491.post-16110782608578449082011-03-18T17:53:17.387+05:302011-03-18T17:53:17.387+05:30Hi,
This is all marvelous and fine, but in my vie...Hi,<br /><br />This is all marvelous and fine, but in my view, exemples showed theres are not really interresting for a code review. Most of them can be found in tool like sonar/PMD/FindBug/Checkstyle automaticaly anyway. And really theses things are details or in some case more about a matter of taste.<br /><br />For my taste :<br /><br />Integer myVal = new Integer(10); <br />I really don'tNicolasnoreply@blogger.comtag:blogger.com,1999:blog-9150561117329868491.post-89170481959168203072011-03-17T22:17:04.219+05:302011-03-17T22:17:04.219+05:30thx for sharing that pointer... Appreciate it :)
...thx for sharing that pointer... Appreciate it :)<br /><br />CheersDinuka Arseculeratnehttps://www.blogger.com/profile/13924080326710656628noreply@blogger.comtag:blogger.com,1999:blog-9150561117329868491.post-20088541590635321162011-03-17T22:14:20.382+05:302011-03-17T22:14:20.382+05:30Referring to Log4J: The first line of LOG.debug() ...Referring to Log4J: The first line of LOG.debug() is a conditional that calls LOG.isDebugEnabled(), so your recommended preemptive check is not necessary unless you are attempting to avoid method parameter construction, which your example does not illustrate.<br /><br />http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/Category.html#debug(java.lang.Object)<br /><br />//NO!<br />if (Anonymousnoreply@blogger.comtag:blogger.com,1999:blog-9150561117329868491.post-55148648278779299922011-03-17T21:35:21.759+05:302011-03-17T21:35:21.759+05:30Hi Artur,
I actually have not taken the time to t...Hi Artur,<br /><br />I actually have not taken the time to test this feature specifically. is there any article or test done to prove its not working as it is said to be working? thx for bringing this up.. Will investigate on this..<br /><br />Cheers<br />DinukaDinuka Arseculeratnehttps://www.blogger.com/profile/13924080326710656628noreply@blogger.comtag:blogger.com,1999:blog-9150561117329868491.post-67660771332365868982011-03-17T21:32:30.943+05:302011-03-17T21:32:30.943+05:30Have you actually tested your claims about on-stac...Have you actually tested your claims about on-stack allocation of strings thanks to escape analysis? I think you might be suprised of differences between what is promised (or, even better, what is wrongly perceived as being promised) and what is really done in JDK1.6.Artur Biesiadowskihttps://www.blogger.com/profile/01153887805003519136noreply@blogger.com